Made a configurable constant #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
RohitRathore1
had a problem deploying
to
openai1
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1819 +/- ##
===========================================
+ Coverage 36.95% 47.65% +10.69%
===========================================
Files 62 64 +2
Lines 6529 6837 +308
Branches 1447 1629 +182
===========================================
+ Hits 2413 3258 +845
+ Misses 3922 3310 -612
- Partials 194 269 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sonichi
requested review from
afourney,
joshkyh,
Tylersuard,
sidhujag,
LinxinS97,
JieyuZ2 and
LeoLjl
|
would it be better to make the intro msg an argument instead of configurable constant? |
joshkyh
reviewed
Mar 5, 2024
sonichi
approved these changes
Mar 10, 2024
@JieyuZ2 's suggestion can be addressed in a future PR if there are such needs. |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Made a configurable constant * Fix typo Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com> --------- Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This modification ensure that the introduction message is easily configurable and can be changed without altering the method's logic directly.
Related issue number
Closes #1690
Checks